688467cf by Chris Boden

Fixed a bug on PagePermissions

1 parent 885ecdae
...@@ -70,7 +70,7 @@ class PagePermissions { ...@@ -70,7 +70,7 @@ class PagePermissions {
70 } 70 }
71 71
72 // Meta value hasn't been set, getting settings defaults 72 // Meta value hasn't been set, getting settings defaults
73 if ('' === $data = array_shift(get_post_meta($post_id, self::META))) { 73 if (NULL === $data = array_shift(get_post_meta($post_id, self::META))) {
74 $data = Array(self::ELE_SEL => $settings[self::ELE_SEL], self::ELE_CUST => $settings[self::ELE_CUST]); 74 $data = Array(self::ELE_SEL => $settings[self::ELE_SEL], self::ELE_CUST => $settings[self::ELE_CUST]);
75 } 75 }
76 76
...@@ -204,7 +204,7 @@ class PagePermissionsAdmin { ...@@ -204,7 +204,7 @@ class PagePermissionsAdmin {
204 $selected = ($post->ID == 0 ? self::getOptions() : array_shift(get_post_meta($post->ID, PagePermissions::META))); 204 $selected = ($post->ID == 0 ? self::getOptions() : array_shift(get_post_meta($post->ID, PagePermissions::META)));
205 205
206 // If the post doesn't have the field saved get defaults 206 // If the post doesn't have the field saved get defaults
207 if (empty($selected)) { 207 if (is_null($selected)) {
208 $selected = self::getOptions(); 208 $selected = self::getOptions();
209 } 209 }
210 210
...@@ -277,7 +277,7 @@ class PagePermissions_Actions { ...@@ -277,7 +277,7 @@ class PagePermissions_Actions {
277 $new[PagePermissions::ELE_CUST] = Array(); 277 $new[PagePermissions::ELE_CUST] = Array();
278 } 278 }
279 279
280 if (empty($current)) { 280 if (is_null($current)) {
281 add_post_meta($real_id, PagePermissions::META, $new, true); 281 add_post_meta($real_id, PagePermissions::META, $new, true);
282 } else { 282 } else {
283 update_post_meta($real_id, PagePermissions::META, $new); 283 update_post_meta($real_id, PagePermissions::META, $new);
...@@ -296,7 +296,7 @@ class PagePermissions_Actions { ...@@ -296,7 +296,7 @@ class PagePermissions_Actions {
296 $innerhtml = ''; 296 $innerhtml = '';
297 if ('0' !== ($change_field = (isset($_GET['attachment_id']) ? 'attachments[' . $_GET['attachment_id'] . '][' . PagePermissions::META . ']' : '0'))) { 297 if ('0' !== ($change_field = (isset($_GET['attachment_id']) ? 'attachments[' . $_GET['attachment_id'] . '][' . PagePermissions::META . ']' : '0'))) {
298 $selected = array_shift(get_post_meta($_GET['attachment_id'], PagePermissions::META)); 298 $selected = array_shift(get_post_meta($_GET['attachment_id'], PagePermissions::META));
299 if (empty($selected)) { 299 if (is_null($selected)) {
300 $selected = PagePermissionsAdmin::getOptions(); 300 $selected = PagePermissionsAdmin::getOptions();
301 } 301 }
302 302
...@@ -333,7 +333,7 @@ class PagePermissions_Actions { ...@@ -333,7 +333,7 @@ class PagePermissions_Actions {
333 $new[PagePermissions::ELE_CUST] = Array(); 333 $new[PagePermissions::ELE_CUST] = Array();
334 } 334 }
335 335
336 if (empty($current)) { 336 if (is_null($current)) {
337 add_post_meta($real_id, PagePermissions::META, $new, true); 337 add_post_meta($real_id, PagePermissions::META, $new, true);
338 } else { 338 } else {
339 update_post_meta($real_id, PagePermissions::META, $new); 339 update_post_meta($real_id, PagePermissions::META, $new);
......